Allow ranked collective members below mininum required rank to vote but with zero weight #6991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the
ranked_collectivepallet to allow ranked collective members below the minimum required rank to vote. But this vote doesn't affect the outcome of a poll because it carries zero weight (0 voting power).Currently, a vote by members below the minimum rank results in a
RankTooLowerror. This PR removes this error and allows such members to vote successfully. This meansTally.bare_ayesincreases by one for such members, but no changes are made toAyes/NaysThis PR also extends
Tallyto include bothout_of_rank_ayesandout_of_rank_naysfor tracking votes of members below the minimum rankThis PR is a replacement for PR 3461, which I had to abandon because a little security mishap required me to re-write that PRs history and force-push.
Implements the feature discussed in #3210.