Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove global variable SharedClient #390

Open
niklasad1 opened this issue Sep 30, 2022 · 0 comments
Open

remove global variable SharedClient #390

niklasad1 opened this issue Sep 30, 2022 · 0 comments

Comments

@niklasad1
Copy link
Member

Because the staking miner is using the trait MinerConfig and MinerConfig::solution_weight doesn't take &self it's not possible to feed an RPC client in there without using a global variable.

This requires refactoring the MinerConfig trait to take &self perhaps it could be possible to adapt this trait accept both sync and async variants of solution_weight as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@niklasad1