Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code to remove instances of createType #1409

Open
Imod7 opened this issue Mar 6, 2024 · 0 comments
Open

Refactor code to remove instances of createType #1409

Imod7 opened this issue Mar 6, 2024 · 0 comments

Comments

@Imod7
Copy link
Contributor

Imod7 commented Mar 6, 2024

Description
Using as a reference this comment that advises against the use of createType, we should replace all instances of createType in this repo. The changes should happen gradually and in small individual PRs to avoid breaking any existing functionality and testing thoroughly.

Example
This modification was implemented in this PR and can serve as an example for the rest of the replacements.

Credits
Special thanks to @TarikGul for reviewing the aforementioned PR and for suggesting this change (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant