Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New execution phases in blocks endpoint #1542

Open
Imod7 opened this issue Nov 9, 2024 · 0 comments
Open

New execution phases in blocks endpoint #1542

Imod7 opened this issue Nov 9, 2024 · 0 comments

Comments

@Imod7
Copy link
Contributor

Imod7 commented Nov 9, 2024

Proposed Change

As soon as the two new phases, ApplyInherent and AfterInherent, proposed in this PR paritytech/polkadot-sdk#3666 are applied (PR merged and a new runtime release includes these phases), we should take them into account also in Sidecar.

Code Change

In the conditional statement here we check the different phases (ApplyExtrinsic, Finalization and Initialization) which correspond to the current phases in polkadot-sdk. As soon as the new phases (ApplyInherent and AfterInherent) are included, we should check for those in the same conditional statement.

Additional Information

Also related to this Sidecar issue #1538 and its fix PR #1541

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant