Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified Address Format: Review & Update Sidecar code accordingly #1563

Open
Imod7 opened this issue Dec 23, 2024 · 0 comments
Open

Unified Address Format: Review & Update Sidecar code accordingly #1563

Imod7 opened this issue Dec 23, 2024 · 0 comments

Comments

@Imod7
Copy link
Contributor

Imod7 commented Dec 23, 2024

Description of Upcoming Change

WFC Unifying Polkadot Ecosystem Address Format was voted which means that the ss58 representation of addresses will be unified as described in this forum post section.

Relevant Resources

Sidecar Checks & Possible Updates

We need to review and update (if necessary) Sidecar's codebase to ensure compatibility with the new address format. From a first check, we would need to:

  • Review that addresses in endpoint responses are in the expected format, e.g. blocks endpoint (example) > under extrinsics > events > e.g. 5 > data > there is an address: no ss58 representation since here we call fetchEvents which calls query.system.events()
  • Review validateAddress function
  • Update validateAddress > allNetworks code
    • allnetworks is imported from util-crypto to obtain the network in which this address belongs to.
    • allnetworks in util crypto is using knownSubstrate
    • which is fetching the network from ss58-registry which will become obsolete.
  • Review & update the tests where the chain defined based on the ss58Prefix.
  • Review the mocked registries in all tests.

cc: @IkerAlus @TarikGul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant