Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rimraf's bin.js file non existent #119

Closed
bee344 opened this issue Feb 28, 2024 · 3 comments
Closed

rimraf's bin.js file non existent #119

bee344 opened this issue Feb 28, 2024 · 3 comments

Comments

@bee344
Copy link

bee344 commented Feb 28, 2024

In version v5.0.5 of rimraf, the file structure changes and bin.js is no longer present in the node_modules, which causes this to fail and therefore crashes the build of txwrapper. We need to further check how deep this difference goes and refactor the call.

Rel: #358

@ryanleecode
Copy link

yeah looks busted rn. cc @TarikGul

➜  asset-transfer-api git:(chore/update-nodenext) yarn build    
rimraf dist .tshy .tshy-build
node:internal/modules/cjs/loader:1251
  throw err;
  ^

Error: Cannot find module '/home/ryan/Documents/Repositories/paritytech/asset-transfer-api/node_modules/rimraf/bin'
Require stack:
- /home/ryan/Documents/Repositories/paritytech/asset-transfer-api/node_modules/@substrate/dev/scripts/importBinary.cjs
- /home/ryan/Documents/Repositories/paritytech/asset-transfer-api/node_modules/@substrate/dev/scripts/substrate-exec-rimraf.cjs
    at Module._resolveFilename (node:internal/modules/cjs/loader:1248:15)
    at Module._load (node:internal/modules/cjs/loader:1074:27)
    at TracingChannel.traceSync (node:diagnostics_channel:315:14)
    at wrapModuleLoad (node:internal/modules/cjs/loader:217:24)
    at Module.require (node:internal/modules/cjs/loader:1339:12)
    at require (node:internal/modules/helpers:135:16)
    at importBinary (/home/ryan/Documents/Repositories/paritytech/asset-transfer-api/node_modules/@substrate/dev/scripts/importBinary.cjs:16:12)
    at Object.<anonymous> (/home/ryan/Documents/Repositories/paritytech/asset-transfer-api/node_modules/@substrate/dev/scripts/substrate-exec-rimraf.cjs:6:1)
    at Module._compile (node:internal/modules/cjs/loader:1546:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1691:10) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/home/ryan/Documents/Repositories/paritytech/asset-transfer-api/node_modules/@substrate/dev/scripts/importBinary.cjs',
    '/home/ryan/Documents/Repositories/paritytech/asset-transfer-api/node_modules/@substrate/dev/scripts/substrate-exec-rimraf.cjs'
  ]
}

Node.js v22.9.0

@TarikGul
Copy link
Member

I have a decent solution for the following, I'll get something going and ping you.

@TarikGul
Copy link
Member

This is now fixed and resolved in #129, next release will reflect it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants