This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
let initialize function in pallet-grandpa/pallet-babe and other session managed pallets be pub
#14556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on managed pallets be pub
|
see #14555 (comment) |
sam0x17
previously approved these changes
Jul 20, 2023
davxy
suggested changes
Jul 20, 2023
There was a problem hiding this comment.
Before merge I'd like to have an opinion on #14555 (comment)
|
Think we should close this; existing issue still has an unanswered comment, and it isn't clear yet that this PR is doing the right thing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #14555
In this pr, we hope to let those function be
pub, which is called underOneSessionHandler::on_genesis_sessionfunction.More details pleases refers to issue #14555