Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store nomination pool total value locked on-chain #155

Closed
liamaharon opened this issue Jul 12, 2023 · 1 comment · Fixed by #1322 · May be fixed by paritytech/substrate#14775
Closed

Store nomination pool total value locked on-chain #155

liamaharon opened this issue Jul 12, 2023 · 1 comment · Fixed by #1322 · May be fixed by paritytech/substrate#14775
Assignees
@PieWol
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. I5-enhancement An additional feature request. T1-FRAME This PR/Issue is related to core FRAME, the framework.

Comments

@liamaharon
Copy link
Contributor

liamaharon commented Jul 12, 2023 •
edited
Loading

Tracking issue for finishing off paritytech/substrate#13319

I'm planning to work on this next month when I get spare time, but it could also make a good mentor issue if someone wanted to pick it up before then (hello pba? ;)).
@liamaharon liamaharon mentioned this issue Jul 12, 2023
Closed
4 tasks
@PieWol
Copy link
Contributor

PieWol commented Aug 12, 2023

Hey, @liamaharon I would like to work on this.

@PieWol PieWol mentioned this issue Aug 15, 2023
Draft
@juangirini juangirini transferred this issue from paritytech/substrate Aug 24, 2023
@the-right-joyce the-right-joyce added I5-enhancement An additional feature request. C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. T1-FRAME This PR/Issue is related to core FRAME, the framework. and removed J0-enhancement labels Aug 25, 2023
@PieWol PieWol mentioned this issue Aug 30, 2023
Merged
Ank4n added a commit that referenced this issue Oct 1, 2023
@PieWol @liamaharon
@kianenigma @Ank4n
Tvl pool staking (#1322)
e8baac7 
What does this PR do?
- Introduced the TotalValueLocked storage for nomination-pools. 
- introduced a slashing api in mock.rs 
- additional test for tracking a slashing event towards a pool without
sub-pools
- migration for the nomination-pools (V6 to V7) with
`VersionedMigration`

Why are these changes needed?
this is the continuation of the work by @kianenigma in this
[PR](paritytech/substrate#13319)

How were these changes implemented and what do they affect?
- It's an extra StorageValue that's modified whenever funds flow in or
out of staking for any of the `bonded_account` of `BondedPools`
- The `PoolSlashed`event is now emitted even when no `SubPools` are
found

Closes #155
KSM: HHEEgVzcqL3kCXgsxSfJMbsTy8dxoTctuXtpY94n4s8F4pS

---------

Co-authored-by: Liam Aharon <[email protected]>
Co-authored-by: Kian Paimani <[email protected]>
Co-authored-by: Ankan <[email protected]>
Co-authored-by: Ankan <[email protected]>
Co-authored-by: command-bot <>
@github-project-automation github-project-automation bot moved this from In Progress to Done in Runtime / FRAME Oct 1, 2023
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this issue Mar 25, 2024
@PieWol @liamaharon
@kianenigma @Ank4n
Tvl pool staking (paritytech#1322)
b6bd08e 
What does this PR do?
- Introduced the TotalValueLocked storage for nomination-pools. 
- introduced a slashing api in mock.rs 
- additional test for tracking a slashing event towards a pool without
sub-pools
- migration for the nomination-pools (V6 to V7) with
`VersionedMigration`

Why are these changes needed?
this is the continuation of the work by @kianenigma in this
[PR](paritytech/substrate#13319)

How were these changes implemented and what do they affect?
- It's an extra StorageValue that's modified whenever funds flow in or
out of staking for any of the `bonded_account` of `BondedPools`
- The `PoolSlashed`event is now emitted even when no `SubPools` are
found

Closes paritytech#155
KSM: HHEEgVzcqL3kCXgsxSfJMbsTy8dxoTctuXtpY94n4s8F4pS

---------

Co-authored-by: Liam Aharon <[email protected]>
Co-authored-by: Kian Paimani <[email protected]>
Co-authored-by: Ankan <[email protected]>
Co-authored-by: Ankan <[email protected]>
Co-authored-by: command-bot <>
jonathanudd pushed a commit to jonathanudd/polkadot-sdk that referenced this issue Apr 10, 2024
@svyatonik @bkchr
Sign PoA transactions from wasm env (paritytech#155)
b5bdbeb 
* sign PoA transactions from wasm env

* cargo fmt --all
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PieWol PieWol

Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. I5-enhancement An additional feature request. T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
Runtime / FRAME
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tvl pool staking PieWol/polkadot-sdk
Tvl pool staking PieWol/substrate
3 participants
@liamaharon @PieWol @the-right-joyce