Add LiveViewTest.assert_* macros to locals_without_parens config #5991
Conversation
So one can simply add `:phoenix` to their `:plugins` option in `.formatter.exs` and it will not automatically include parens to those functions when `mix format`ing
There was a problem hiding this comment.
Please also add refute_push_event/4 (phoenixframework/phoenix_live_view#3490)
.formatter.exs
Outdated
| assert_redirect: 2, | ||
| assert_redirect: 3, | ||
| assert_redirected: 2, | ||
| assert_reply: 3 |
There was a problem hiding this comment.
We already have assert_reply/3 in line 53. I don't know if duplicates are a problem though.
There was a problem hiding this comment.
As for duplicates, they shouldn't affect the code, as the function that checks them will work the same (it basically just Enum.any? this list here: https://github.com/elixir-lang/elixir/blob/44107f1010229f58d899177e34eb04357a075ab3/lib/elixir/lib/code/formatter.ex#L180-L185
IMO we should leave it here, just in case someday someone removes one of these sections.
|
Not sure if the failing checks have something to do with my change. Anything else I need to do here? |
So one can simply add
:phoenixto their:pluginsoption in.formatter.exsand it will not automatically include parens to those functions whenmix formatingOriginal PR phoenixframework/phoenix_live_view#3535