Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change in debug_heex_annotations should force recompilation #3565

Open
ruslandoga opened this issue Dec 11, 2024 · 2 comments
Open

change in debug_heex_annotations should force recompilation #3565

ruslandoga opened this issue Dec 11, 2024 · 2 comments

Comments

@ruslandoga
Copy link
Contributor

ruslandoga commented Dec 11, 2024

👋

Environment

  • Elixir version (elixir -v): 1.17.3
  • Phoenix version (mix deps): 1.7.18
  • Phoenix LiveView version (mix deps): 1.0.0
  • Operating system: Darwin 24.1.0
  • Browsers you attempted to reproduce this bug on (the more the merrier):
  • Does the problem persist after removing "assets/node_modules" and trying again? Yes/no:

Actual behavior

Making this change in config/dev.exs

config :phoenix_live_view,
  # Include HEEx debug annotations as HTML comments in rendered markup
- debug_heex_annotations: true,
+ debug_heex_annotations: false,
  # Enable helpful, but potentially expensive runtime checks
  enable_expensive_runtime_checks: true

and running the app again with iex -S mix doesn't seem to recompile the templates and keeps showing the annotations in the templates rendered with Phoenix.View.render_to_string

Right now I'm using mix compile --force as a workaround.

Expected behavior

Maybe debug_heex_annotations could force recompilation of the templates.

@andrewtimberlake
Copy link

The docs do say:
“Changing this configuration will require mix clean and a full recompile.”

@ruslandoga
Copy link
Contributor Author

ruslandoga commented Dec 11, 2024

I think it can be better -- automatic :)

Or at least we can include that note in the generated config files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants