-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit correct types for emscripten enums in class namespaces #15
Comments
@isaac-mason Thank you for all of your work on this repo I was wondering if this issue is related to: https://github.com/pmndrs/webidl-dts-gen/blame/main/packages/webidl-dts-gen/src/convert-idl.ts#L546 Nowadays, is it possible in TypeScript to do |
Hey @regnaio, this isn't related no, this tool generates types that match the output of the emscripten webidl binder. This issue is for emitting correct types for enums under namespaces, e.g. For enums to be accessible via There's a somewhat related issue on the emscripten repo for prefixing enums here: emscripten-core/emscripten#13243 You could comment on that issue or raise another on the emscripten repo if you'd like. That said, if you'd like to see it happen, you'll probably need to contribute the change yourself :) For a workaround, see: fabmax/PhysX#1 If you were to do this and still wanted to use |
Thank you so much, @isaac-mason , for your links and pointers helping me in the right direction I feel like you read my mind. Indeed, I was using I've added a comment to emscripten-core/emscripten#13243 |
No worries @regnaio! 🙂 |
https://github.com/emscripten-core/emscripten/blob/dd6774a840872b0902e69cfcb20d553359f52374/tools/webidl_binder.py#L798
The text was updated successfully, but these errors were encountered: