Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: P-Table Pagination replaces 'All' pagination with ' ' on the paginator dropdown when using filterGlobal method #17025

Open
cshelton-png opened this issue Dec 11, 2024 · 1 comment · May be fixed by #17227
Labels
Resolution: Help Wanted Issue or pull request requires extra help and feedback
Milestone

Comments

@cshelton-png
Copy link

Describe the bug

Version: 17.18.11, also seen on 17.18.13 through using the PrimeNG documentation Stackblitz.

Issue: Any table that uses the 'All' option for pagination will have the 'All' text replaced with ' ' when using the filterGlobal method to search for specific table results.

I was able to edit the Stackblitz version of the p-table from the PrimeNG documentation (https://primeng.org/table#filter-basic) to confirm this wasn't an issue from custom code and it appears to be at least a v17 bug. I was unable to test v18. This doesn't appear to affect the functionality, but I have an open bug on my end and cannot find a workaround for this issue.

Environment

Using version 17.18.11 on Angular version 18.2.8 with Node version 22.11.0

Reproducer

No response

Angular version

18.2.8

PrimeNG version

17.18.11

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

22.11.0

Browser(s)

No response

Steps to reproduce the behavior

  1. Configure a table with a simple search function
  2. Add "{showAll: 'All'}" to the pagination dropdown option array.
  3. Select "All" from the pagination dropdown
  4. Do a search of any data in the table
  5. Observe that 'All' in the dropdown is now replaced with a blank space, which the browser shows as '&nbsp' in the dev tools.

Expected behavior

'All' should stay populated in the paginator dropdown until user action changes this option or pagination is set to 'false'

@cshelton-png cshelton-png added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 11, 2024
@mertsincan mertsincan added Resolution: Help Wanted Issue or pull request requires extra help and feedback and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 16, 2024
@mertsincan mertsincan added this to the Future milestone Dec 16, 2024
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Dec 16, 2024
Copy link

Due to PrimeNG team's busy roadmap, this issue is available for anyone to work on. Make sure to reference this issue in your pull request. ✨ Thank you for your contribution! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Help Wanted Issue or pull request requires extra help and feedback
Projects
Status: Review
Development

Successfully merging a pull request may close this issue.

2 participants