Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CascadeSelect: sub list has double padding #17233

Open
4 tasks
honboubao opened this issue Dec 27, 2024 · 0 comments · May be fixed by #17234
Open
4 tasks

CascadeSelect: sub list has double padding #17233

honboubao opened this issue Dec 27, 2024 · 0 comments · May be fixed by #17234
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Milestone

Comments

@honboubao
Copy link
Contributor

honboubao commented Dec 27, 2024

Describe the bug

The second and subsequent levels of the cascaded options lists of the CascadeComponent have double the amount of padding applied. Padding is applied once on p-cascadeselect-sub.p-cascadeselect-list and again on ul.p-cascadeselect-list.

grafik

Pull Request Link

#17234

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://primeng.org/cascadeselect

Environment

Windows 10
Firefox 128.3.1esr

Angular version

not relevant

PrimeNG version

v19

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

  1. Click on CascadeSelect to open options
  2. Navigate to second level of options
  3. Hover mouse over option on second level to highlight
  4. Observe greater white area around highlighted options on second level list compared to first level list

Expected behavior

Padding should be consistent on every level of the cascaded option lists.

@honboubao honboubao added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 27, 2024
honboubao pushed a commit to honboubao/primeng that referenced this issue Dec 27, 2024
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 30, 2024
@mertsincan mertsincan added this to the 19.0.3 milestone Dec 30, 2024
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
Status: Review
Development

Successfully merging a pull request may close this issue.

2 participants