Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip: appendTo not working when targeting elements besides body #17243

Open
1 of 4 tasks
mattb103190 opened this issue Dec 28, 2024 · 2 comments · May be fixed by #17265
Open
1 of 4 tasks

Tooltip: appendTo not working when targeting elements besides body #17243

mattb103190 opened this issue Dec 28, 2024 · 2 comments · May be fixed by #17265
Labels
Resolution: Help Wanted Issue or pull request requires extra help and feedback
Milestone
Future

Comments

@mattb103190
Copy link

mattb103190 commented Dec 28, 2024 •
edited
Loading

Describe the bug

appendTo seems broken for me on the tooltip component when giving a target element that's not the body.

Side note: autoHide also doesn't seem to do anything.

Pull Request Link

No response

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/edit/github-h6dcpcrk?file=src%2Fapp%2Fapp.component.html

Environment

Ubuntu

Angular version

19.0.5

PrimeNG version

v19

Node version

20.9.0

Browser(s)

No response

Steps to reproduce the behavior

Add appendTo with a target element to a tooltip component, hover.

Expected behavior

The tooltip should correctly be applied as a child element to the target element, and be removed from the DOM when hovered off.
@mattb103190 mattb103190 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 28, 2024
@mattb103190 mattb103190 changed the title Tooltip: appendTo not working when targetting elements besides body Tooltip: appendTo not working when targeting elements besides body Dec 28, 2024
@mertsincan mertsincan added Resolution: Help Wanted Issue or pull request requires extra help and feedback and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 30, 2024
@mertsincan mertsincan added this to the Future milestone Dec 30, 2024
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Dec 30, 2024
@github-actions GitHub Actions
Copy link

Due to PrimeTek's demanding roadmap for PrimeNG, this issue is available for anyone to work on. Make sure to reference this issue in your pull request. ✨ Thank you for your contribution! ✨

@mark7p mark7p linked a pull request Dec 31, 2024 that will close this issue
Open
@mark7p
Copy link
Contributor

mark7p commented Dec 31, 2024

Hi @mattb103190 I submitted a PR that solves the appendTo bug.

Side note: autoHide also doesn't seem to do anything.

Can you create another issue for autoHide? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Resolution: Help Wanted Issue or pull request requires extra help and feedback
Projects
PrimeNG
Status: Review
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Fix: ToolTip(#17243 ) - AppendTo bug mark7p/primeng
3 participants
@mertsincan @mattb103190 @mark7p