Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Impossible to inline text with icon on same row with jekyll_octicons. #1032

Open
skatkov opened this issue Sep 23, 2024 · 3 comments
Open

Comments

@skatkov
Copy link

skatkov commented Sep 23, 2024

Describe the bug

When using octoicons_jekyll it's impossible to inline icon with a text on a same row.

Steps to reproduce

Steps to reproduce the behavior:

  1. Install jekyll-octicons
  2. Add a following markup:
<button>
   {%- octicon alert height:32 class:"right left" aria-label:hi -%} Button
</button>

Result

Icon and button are on different line, I would expect it to be inline

Expected behavior

I would expect icon and text to be inlined. And I can't find any way to make it inline. Is there a setting I'm missing?

Screenshots

Screenshot 2024-09-23 at 15 08 21

Device details

Desktop (please complete the following information):
OSX, Firefox.

@0xventure-s
Copy link

Any update of this?

@tallys
Copy link
Contributor

tallys commented Dec 2, 2024

Hi, thanks for opening this issue, unfortunately we are not going to prioritize this at this time, but will add this to the backlog for consideration in the future.

@skatkov
Copy link
Author

skatkov commented Dec 4, 2024

In case anyone lands here, here is a workaround that I'm using in my projects.

With tailwindcss:

<button class="inline-flex">
   {%- octicon alert height:32 class:"right left" aria-label:hi -%} Button
</button>

or with plain html/css:

<button style="display:inline-flex">
   {%- octicon alert height:32 class:"right left" aria-label:hi -%} Button
</button>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants