Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage containers replacing after upgrade #2660

Open
scottmack111 opened this issue Nov 21, 2024 · 3 comments
Open

Storage containers replacing after upgrade #2660

scottmack111 opened this issue Nov 21, 2024 · 3 comments
Labels
awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). kind/bug Some behavior is incorrect or out of spec

Comments

@scottmack111
Copy link

Describe what happened

After upgrading from from 5.89.0 to 6.9.0 im trying to clear out some of our deprecation warnings.

When updating my azure.storage.Container resources to use storageAccountId instead of storageAccountName its causing a replacement of the resource

Sample program

Replace

storageAccountName: StorageAccount.name

With

storageAccountId: StorageAccount.id

Log output

        "diffReasons": [
            "storageAccountId",
            "storageAccountName"
        ],
        "replaceReasons": [
            "storageAccountId",
            "storageAccountName"
        ],
        "detailedDiff": {
            "storageAccountId": {
                "kind": "add-replace",
                "inputDiff": false
            },
            "storageAccountName": {
                "kind": "delete-replace",
                "inputDiff": false
            }
        }

Affected Resource(s)

azure.storage.Container

Output of pulumi about

CLI
Version 3.139.0
Go Version go1.23.3
Go Compiler gc

Plugins
KIND NAME VERSION
resource azure 6.9.0
resource azuread 6.0.1
resource kubernetes 4.18.3
language nodejs unknown
resource random 4.16.7

Host
OS Microsoft Windows 11 Pro
Version 10.0.22631 Build 22631
Arch x86_64

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@scottmack111 scottmack111 added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Nov 21, 2024
@thomas11
Copy link
Contributor

Hi @scottmack111, do you get any deprecation warning about storageAccountName in v5.89? If yes, please fix it while on v5, then upgrade to v6.

In case you haven't seen it, there's an Azure Classic v6 Migration Guide.

@thomas11 thomas11 added awaiting-feedback Blocked on input from the author and removed needs-triage Needs attention from the triage team labels Nov 22, 2024
@scottmack111
Copy link
Author

Hi @scottmack111, do you get any deprecation warning about storageAccountName in v5.89? If yes, please fix it while on v5, then upgrade to v6.

In case you haven't seen it, there's an Azure Classic v6 Migration Guide.

Hi Thomas,

No I do not have the deprecation warnings on 5.89.0, only in v6 up. I've just tried this morning to migrate on 5.89 but the property storageAccountId doesnt exist

@pulumi-bot pulumi-bot added needs-triage Needs attention from the triage team and removed awaiting-feedback Blocked on input from the author labels Nov 25, 2024
@thomas11
Copy link
Contributor

thomas11 commented Dec 2, 2024

Hi @scottmack111, it turns out this an upstream problem with the Terraform provider. There's no convenient workaround at this time, but you can keep using storageAccountName until the next major release, at which point they plan to have a better migration path.

@thomas11 thomas11 added awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). and removed needs-triage Needs attention from the triage team labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Development

No branches or pull requests

3 participants