Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings in npm install for nodejs package #2696

Open
pierskarsenbarg opened this issue Nov 28, 2024 · 2 comments
Open

Warnings in npm install for nodejs package #2696

pierskarsenbarg opened this issue Nov 28, 2024 · 2 comments
Labels
awaiting-feedback Blocked on input from the author kind/enhancement Improvements or new features

Comments

@pierskarsenbarg
Copy link
Member

When installing the latest NPM package @pulumi/gcp I'm seeing some deprecation warnings from the read-package-json package that we reference here:

"read-package-json": "^2.0.13",

npm warn deprecated [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated [email protected]: This package is no longer supported. Please use @npmcli/package-json instead.
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Nov 28, 2024
@VenelinMartinov
Copy link
Contributor

Hey @pierskarsenbarg, thanks for reporting. Can you help me understand the impact here? The deprecated warnings are not great but can be silenced, right?

This is, unfortunately, somewhat tricky to fix. I had a go but the module is used in our custom typescript overlay and we'd need to backfill a lot of tests here to change that.

@VenelinMartinov VenelinMartinov added kind/enhancement Improvements or new features awaiting-feedback Blocked on input from the author and removed needs-triage Needs attention from the triage team labels Dec 2, 2024
@pierskarsenbarg
Copy link
Member Author

It's more "the warnings aren't great" than anything else and to get them on the radar.

Not sure what the inflight one does but "leaks memory" doesn't sound very good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-feedback Blocked on input from the author kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

3 participants