Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Span link with good DX interface and demo presentation #158

Open
ManiMozaffar opened this issue May 9, 2024 · 3 comments · May be fixed by #726
Open

Support for Span link with good DX interface and demo presentation #158

ManiMozaffar opened this issue May 9, 2024 · 3 comments · May be fixed by #726
Assignees
@Kludex
Labels
Feature Request

Comments

@ManiMozaffar
Copy link

ManiMozaffar commented May 9, 2024 •
edited
Loading

Description

I couldn't find anywhere in docs where it mentioned about span links. That might be something logfire is missing at the moment.
https://opentelemetry.io/docs/concepts/signals/traces/#span-links

It'd be nice to also have this on example, linking a span from frontend, to the backend. I'm interested how that would look in the dashboard as well.
Currently otel sdk interface for span link is some kind of horrible. but I'm questioning if that can be designed better or not.
@ManiMozaffar ManiMozaffar changed the title Support for Span link with DX friendly with demo presentation Support for Span link with DX friendly interface and demo presentation May 9, 2024
@ManiMozaffar ManiMozaffar changed the title Support for Span link with DX friendly interface and demo presentation Support for Span link with good DX interface and demo presentation May 9, 2024
@adriangb
Copy link
Member

adriangb commented May 9, 2024

It's something we're actively working on adding.

Do you have any suggestions for APIs you'd like in the SDK?

@ManiMozaffar
Copy link
Author

ManiMozaffar commented May 9, 2024 •
edited
Loading

Do you have any suggestions for APIs you'd like in the SDK?

Not really, we instrumented kafka batch process and consuming, which then show a really nice links from the first span (message) to the last one. but overall the module that instrumented were a bit messy and highly complicated.
But what I found even more complicated, is how to allow react, our client, to link spans from frontend to the related backend request? If this is show-cased in the demo project, it'd be awesome.

@Kludex Kludex linked a pull request Dec 24, 2024 that will close this issue
Open
@Kludex
Copy link
Member

Kludex commented Dec 24, 2024

We already have support to span links via logfire.span(..., _links=...), but I think we can improve our API.

I've implemented #726 to reopen the discussion.

@Kludex Kludex self-assigned this Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kludex Kludex

Labels
Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve Span Links API pydantic/logfire
3 participants
@adriangb @Kludex @ManiMozaffar