Triggers a warning when overriding fixtures at the same level #13058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
Tusenka
approved these changes
Dec 14, 2024
|
Thanks for the PR @dongfangtianyu. I left a comment on the issue #12952 (comment) that we should discuss to decide if this is the right fix. |
src/_pytest/fixtures.py
Outdated
| f"Fixture definition conflict: {name!r} has multiple implementations," | ||
| f"namely {faclist[-1].func!r} and {func} (from: {nodeid!r})." | ||
| ) | ||
| print(msg) |
There was a problem hiding this comment.
Let's turn this into a warning for now
We also might want to propose a ruff rule for this case
There was a problem hiding this comment.
Hi @RonnyPfannschmidt , Could you please let me know which type is more appropriate: PytestWarning or PytestDeprecationWarning?
dongfangtianyu
commented
Dec 18, 2024
src/_pytest/fixtures.py
Outdated
| @@ -1728,6 +1728,20 @@ def _register_fixture( | |||
| ) | |||
|
|
|||
| faclist = self._arg2fixturedefs.setdefault(name, []) | |||
|
|
|||
| by_plugin = fixture_def.baseid == "" | |||
There was a problem hiding this comment.
It's a bit tricky : If the fixture comes from the conftest.py file in the root path, it will bypass this check. Even if it is not bypassed, can't catch errors or warnings.
dongfangtianyu
force-pushed
the
fix-12952
branch
from
2378a99 to
3835460
Compare
dongfangtianyu
force-pushed
the
fix-12952
branch
from
3835460 to
fff8800
Compare
dongfangtianyu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #12952.
Detect fixtures with the same name and from the same nodeid.
closes #XYZWchangelogfolder