New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

segformer: the converter shouldn't be outside the package? #1016

Open

johnnv1 opened this issue Dec 26, 2024 · 1 comment · May be fixed by #1017

johnnv1 commented Dec 26, 2024

i think this https://github.com/qubvel-org/segmentation_models.pytorch/blob/196bbe94604355b40a8982399d6f7a0809129f2f/segmentation_models_pytorch/decoders/segformer/convert_original_to_smp.py shoulnd't be outside smp package itself? in a scripts folder ou something like that (I was reviewing the need for the pillow as a dependency, and this is one of the two places it is used (the other one is in the dataset module, which only have a single sample))

Collaborator

qubvel commented Dec 26, 2024

Yes, indeed, this one could be moved outside of the package 👍 I Would appreciate a PR in case you have the bandwidth, thank you for raising the issue

johnnv1 linked a pull request

that will close this issue

chore (segformer): move decoder converter scripts #1017

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment