Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s/details/options/ in at least gui package manager #6

Open
jasonhemann opened this issue Jun 24, 2024 · 3 comments
Open

s/details/options/ in at least gui package manager #6

jasonhemann opened this issue Jun 24, 2024 · 3 comments

Comments

@jasonhemann
Copy link

I at least had trouble figuring out how to handle a dependency chain in the GUI package manager. I didn't find it obvious to look for dependency management under the Show Details sub-pane. I would have found "Show Options" more informative; the latter suggests something I have agency over. Maybe it's obvious to everyone except me and a couple of students.

(string-constant hide-details-button-label)
(string-constant show-details-button-label))]

The show-details-button-label is currently used at least in the Choose Language dialog under the Language menu. I'm agnostic as to whether that too would be better written as "Show Options".

My suggestion for a change would be either change the label in both places, or define a separate new constant and use that new constant in the GUI package manager.

Happy to work up a suggestion of what I have in mind, at least for the English language version. This, however, seems like a change that would impact localization and $n$ different languages, $n-1$ of which I do not speak.

@rfindler
Copy link
Member

I think the intention with "show details" was that the "details" are details of what "dwim" is going to, ie the "details of what you mean".

Can you say more about the dependencies and what happened and what you expected to happen?

@jasonhemann
Copy link
Author

I think the intention with "show details" was that the "details" are details of what "dwim" is going to, ie the "details of what you mean".

That makes sense too! I think to me the current phrasing doesn't convey that there are configurable options underneath that menu. I perfectly expected to see the raco pkg line. It just didn't even cross my mind that I would have the option to /change/ those details. Most "Details" menus that I recall are strictly informative (below are quickly googled examples of the kind of thing I have in mind). I think something like "Additional Configuration" or "Show Additional Options" would have led me to look there.

As far as the dependencies I was mentioning, it's merely that right now gui-pkg-manager is re-using the two string constants used for the "Choose Language" menu.

So if I wanted to change the labels of these buttons, it'd require either (a) a new set of constants for just the gui-pkg-manager ones, or (b) redefining the strings in english-string-constants, which would change the buttons in both places.

Providing semantically different /meanings/ for these button labels should, one imagines, also require translating whatever the new English-language strings are into the $n$ different localizations, in order to keep the menu meanings consistent across languages.

image
image

@rfindler
Copy link
Member

Making new string constants is totally fine. The translators generally follow changes in the string-constants repository and update them as they have time. If you want to make a pull request for this change, be sure to update the version dependencies and thank you for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants