-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
s/details/options/ in at least gui package manager #6
Comments
I think the intention with "show details" was that the "details" are details of what "dwim" is going to, ie the "details of what you mean". Can you say more about the dependencies and what happened and what you expected to happen? |
That makes sense too! I think to me the current phrasing doesn't convey that there are configurable options underneath that menu. I perfectly expected to see the As far as the dependencies I was mentioning, it's merely that right now gui-pkg-manager is re-using the two string constants used for the "Choose Language" menu. So if I wanted to change the labels of these buttons, it'd require either (a) a new set of constants for just the gui-pkg-manager ones, or (b) redefining the strings in english-string-constants, which would change the buttons in both places. Providing semantically different /meanings/ for these button labels should, one imagines, also require translating whatever the new English-language strings are into the |
Making new string constants is totally fine. The translators generally follow changes in the string-constants repository and update them as they have time. If you want to make a pull request for this change, be sure to update the version dependencies and thank you for your time! |
I at least had trouble figuring out how to handle a dependency chain in the GUI package manager. I didn't find it obvious to look for dependency management under the
Show Details
sub-pane. I would have found "Show Options" more informative; the latter suggests something I have agency over. Maybe it's obvious to everyone except me and a couple of students.gui-pkg-manager/gui-pkg-manager-lib/pkg/gui/private/by-source.rkt
Lines 164 to 165 in 70cc905
The
show-details-button-label
is currently used at least in theChoose Language
dialog under theLanguage
menu. I'm agnostic as to whether that too would be better written as "Show Options".My suggestion for a change would be either change the label in both places, or define a separate new constant and use that new constant in the GUI package manager.
Happy to work up a suggestion of what I have in mind, at least for the English language version. This, however, seems like a change that would impact localization and$n$ different languages, $n-1$ of which I do not speak.
The text was updated successfully, but these errors were encountered: