Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm Job Image should still be overridden if Helm Controller is disabled #108

Open
aiyengar2 opened this issue May 25, 2022 · 0 comments
Open

Helm Job Image should still be overridden if Helm Controller is disabled #108

aiyengar2 opened this issue May 25, 2022 · 0 comments
Assignees
@aiyengar2
Labels
bug Something isn't working package/helm-project-operator team/observability&backup

Comments

@aiyengar2
Copy link

aiyengar2 commented May 25, 2022 •
edited
Loading

https://github.com/rancher/helm-project-operator/blob/f1efb28db62cb8a30ef5f3625a8b58702eaa679e/charts/helm-project-operator/templates/deployment.yaml#L79

Even if the embedded helm controller is disabled, the Helm Job Image should still be overridden to ensure that the image deployed into the HelmChart CR by a Helm Project Operator contains private registry details.

Currently, this means that an airgapped RKE2 cluster will not have this image overridden on deployment by the operator
@aiyengar2 aiyengar2 self-assigned this May 25, 2022
@aiyengar2 aiyengar2 added the bug Something isn't working label May 25, 2022
@mallardduck mallardduck transferred this issue from rancher/helm-project-operator Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aiyengar2 aiyengar2

Labels
bug Something isn't working package/helm-project-operator team/observability&backup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mallardduck @aiyengar2 @jbiers