Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Ray build from source setup doesn't work for github codespace #49470

Open
SaSikun opened this issue Dec 28, 2024 · 1 comment
Open

[core] Ray build from source setup doesn't work for github codespace #49470

SaSikun opened this issue Dec 28, 2024 · 1 comment
Labels
bug Something that is supposed to be working; but isn't

Comments

@SaSikun
Copy link

SaSikun commented Dec 28, 2024

What happened + What you expected to happen

Following build from source documentation, I tried to install all necessary dependencies and build ray, somehow on github codespace I cannot access bazel binary after a successful installation.

@SaSikun ➜ /workspaces/ray (master) $ ci/env/install-bazel.sh
<omit a few output>
+ chmod +x /home/codespace/bin/bazel
+ bazel --version
bazel 6.5.0
+ echo
@SaSikun ➜ /workspaces/ray (master) $ echo $?
0
@SaSikun ➜ /workspaces/ray (master) $ bazel --version
bash: bazel: command not found
  • bazel installation script does succeed
  • bazel --version does output expected version after installation
  • while it cannot be located in my shell env

Platform information

@SaSikun ➜ /workspaces/ray (master) $ uname -a 
Linux codespaces-b37228 6.5.0-1025-azure #26~22.04.1-Ubuntu SMP Thu Jul 11 22:33:04 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
@SaSikun ➜ /workspaces/ray (master) $ lscpu
Architecture:                       x86_64
CPU op-mode(s):                     32-bit, 64-bit
Byte Order:                         Little Endian
Address sizes:                      48 bits physical, 48 bits virtual

Versions / Dependencies

N/A

Reproduction script

ci/env/install-bazel.sh

Issue Severity

Low: It annoys or frustrates me.

@SaSikun SaSikun added bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Dec 28, 2024
@dentiny
Copy link
Contributor

dentiny commented Dec 28, 2024

I think our setup script doesn't handle default executable installation path for github codespace, for example appending /home/codespace/bin/bazel to your PATH should work.

On fixing the script, add one line at the end export PATH=$PATH:$(which bazel) should work

@dentiny dentiny removed the triage Needs triage (eg: priority, bug/not-bug, and owning component) label Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't
Projects
None yet
Development

No branches or pull requests

2 participants