[core][compiled graphs] Rename adag -> cgraph to clean up API #49448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rui Qiao <[email protected]>
kevin85421
approved these changes
Dec 27, 2024
Signed-off-by: Rui Qiao <[email protected]>
rynewang
reviewed
Dec 27, 2024
| @@ -97,10 +97,10 @@ def _get_node_id(self) -> "ray.NodeID": | |||
| z = c.inc.bind(inp) | |||
| dag = MultiOutputNode([x, y, z]) | |||
|
|
|||
| adag = dag.experimental_compile() | |||
| cdag = dag.experimental_compile() | |||
There was a problem hiding this comment.
do we want cdag or cgraph ?
There was a problem hiding this comment.
external API: cgraph
internally, cgraph and cdag can be used interchangeably
here cdag is easier to read since we call experimental_compile() on dag
rynewang
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Clean up API for beta release
Related issue number
Closes #47934
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.