Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[train v2] Populate more deprecation warnings #49455

Open
wants to merge 45 commits into
base: master
Choose a base branch
from
Open

[train v2] Populate more deprecation warnings #49455

wants to merge 45 commits into from

Conversation

justinvyu
Copy link
Contributor

Why are these changes needed?

Add more deprecation warnings

Related issue number

@justinvyu
remove ray.train.report usage within tune code
0f7f22e 
Signed-off-by: Justin Yu <[email protected]>
@justinvyu
Merge branch 'master' of https://github.com/ray-project/ray into tune…
3f44c64 
…_revamp/ray_tune_apis
@justinvyu
add ray.tune accessors for Train v1 APIs
a6dcedb 
Signed-off-by: Justin Yu <[email protected]>
@justinvyu
add tune context
ea480bd 
Signed-off-by: Justin Yu <[email protected]>
@justinvyu
add deprecation messages for train context methods in tune context
2adb15b 
Signed-off-by: Justin Yu <[email protected]>
@justinvyu
add deprecation message if ray.train.get_context is used in ray tune …
b61fbab 
…execution

Signed-off-by: Justin Yu <[email protected]>
@justinvyu
remove ray.air._internal._get_session for sanity
58bcfc6 
Signed-off-by: Justin Yu <[email protected]>
@justinvyu
warn if ray.train.report or ray.train.get_checkpoint are used
59da5b1 
Signed-off-by: Justin Yu <[email protected]>
@justinvyu
lint
554f2ee 
Signed-off-by: Justin Yu <[email protected]>
@justinvyu
fix lint
a6971e1 
Signed-off-by: Justin Yu <[email protected]>
@justinvyu
Merge branch 'master' of https://github.com/ray-project/ray into tune…
4b37af4 
…_revamp/ray_tune_apis
@justinvyu
deprecation warnings gated for now
e919c6a 
Signed-off-by: Justin Yu <[email protected]>
@justinvyu
add (gated) warnings on train context
c2cb318 
Signed-off-by: Justin Yu <[email protected]>
@justinvyu
add pass through Checkpoint, config classes for warnings
0577e56 
Signed-off-by: Justin Yu <[email protected]>
@justinvyu
fix lint
47c799f 
Signed-off-by: Justin Yu <[email protected]>
@justinvyu
mark places to add deprecation warnings
2fd2d78 
Signed-off-by: Justin Yu <[email protected]>
@justinvyu
move stuff to train utils file
6caef4a 
Signed-off-by: Justin Yu <[email protected]>
@justinvyu
log deprecation warnings for Checkpoint / incorrect configs
febc5df 
Signed-off-by: Justin Yu <[email protected]>
@justinvyu
fix lint
6a5d244 
Signed-off-by: Justin Yu <[email protected]>
@justinvyu
Add failure config / checkpoint config deprecation logs
1e980bc 
Signed-off-by: Justin Yu <[email protected]>
@justinvyu
propagate the deprecation message gate env var
7256ef2 
Signed-off-by: Justin Yu <[email protected]>
@justinvyu
fix lint
f86a752 
Signed-off-by: Justin Yu <[email protected]>
@justinvyu
add tests checking for warnings
9728a3d 
Signed-off-by: Justin Yu <[email protected]>
@justinvyu
add to BUILD
4ecfbf2 
Signed-off-by: Justin Yu <[email protected]>
@justinvyu
fix lint
761f327 
Signed-off-by: Justin Yu <[email protected]>
@justinvyu
Merge branch 'master' of https://github.com/ray-project/ray into tune…
8a2a50b 
…_revamp/ray_tune_apis
@justinvyu
add tune trainable fn apis to docs
cc7354b 
Signed-off-by: Justin Yu <[email protected]>
@justinvyu
add tune configs
cc8c62c 
Signed-off-by: Justin Yu <[email protected]>
@justinvyu
remove need for api stability tag on internal util
a4a5c04 
Signed-off-by: Justin Yu <[email protected]>
@justinvyu
maybe fix the checkpoint double reference lint check??
790a78c 
Signed-off-by: Justin Yu <[email protected]>
@justinvyu
Merge branch 'master' of https://github.com/ray-project/ray into tune…
e4a0e6d 
…_revamp/ray_tune_apis
@justinvyu
maybe fix doc
972faef 
Signed-off-by: Justin Yu <[email protected]>
@justinvyu
Merge branch 'master' of https://github.com/ray-project/ray into tune…
cfb927d 
…_revamp/ray_tune_apis
@justinvyu
add get_metadata deprecation message
9f46913 
Signed-off-by: Justin Yu <[email protected]>
@justinvyu
_in_tune_session helper
66da94c 
Signed-off-by: Justin Yu <[email protected]>
@justinvyu
revert backend executor changes
b4bb212 
Signed-off-by: Justin Yu <[email protected]>
@justinvyu
improve deprecation messages for restore
c4fa138 
Signed-off-by: Justin Yu <[email protected]>
@justinvyu
add some limited compatibility for metrics_dataframe
d7b87f2 
Signed-off-by: Justin Yu <[email protected]>
@justinvyu
remove resume_from_checkpoint / metadata usage
2c01955 
Signed-off-by: Justin Yu <[email protected]>
@justinvyu
remaining resume_from_checkpoint
f14cfd5 
Signed-off-by: Justin Yu <[email protected]>
@justinvyu
minor comment removal
3137ff7 
Signed-off-by: Justin Yu <[email protected]>
@justinvyu
raise warnings in deprecated v2 train context methods
e1162a6 
Signed-off-by: Justin Yu <[email protected]>
@justinvyu
some more NotImplementedError -> DeprecationWarning updates
ad707e8 
Signed-off-by: Justin Yu <[email protected]>
@justinvyu
deprecate the torch amp stuff
34c54ab 
Signed-off-by: Justin Yu <[email protected]>
@justinvyu
fix lint
6b85968 
Signed-off-by: Justin Yu <[email protected]>
@justinvyu
Copy link
Contributor Author

Actual diff is here: https://github.com/ray-project/ray/pull/49455/files/b4bb212b98c5c47a36a341951c454c78ebb1e2e8..6b859682e7940af982f5ea7321d9d190e6eff6d6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongpeng-guo hongpeng-guo Awaiting requested review from hongpeng-guo hongpeng-guo is a code owner

@matthewdeng matthewdeng Awaiting requested review from matthewdeng matthewdeng is a code owner

@raulchen raulchen Awaiting requested review from raulchen raulchen is a code owner

@woshiyyya woshiyyya Awaiting requested review from woshiyyya woshiyyya is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@justinvyu