Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[💡 FEATURE REQUEST]: Redis powered lock's #2070

Open
sicet7 opened this issue Nov 25, 2024 · 1 comment
Open

[💡 FEATURE REQUEST]: Redis powered lock's #2070

sicet7 opened this issue Nov 25, 2024 · 1 comment
Assignees
Labels
C-feature-request Category: feature requested, but need to be discussed

Comments

@sicet7
Copy link

sicet7 commented Nov 25, 2024

I failed to find the lock plugin in the Plugin dropdown for this Feature Request so i wrote it manually 😃

Plugin

Lock

I have an idea!

It would be awesome if the Lock Plugin supported other drivers like the KV Plugin does.

The configuration could look something like this:

lock:
  driver: redis
  config: # The config would be up to the implementing plugin to parse
    retry_interval: 100
    client:
      addrs:
          - "${REDIS_HOST:-127.0.0.1}:${REDIS_PORT:-6379}"
      username: "${REDIS_USERNAME}"
      password: "${REDIS_PASSWORD}"
      db: "${REDIS_DB:-0}"

That being said i already have a proof of concept redis locking plugin that could easily be plundered for any useful code for an implementation.

The configuration is like that because i fail to see a scenario where multiple lock drivers would be needed, but i could be wrong.
Also supporting multiple lock drivers at a time would also require a change in the PHP interface and implementation.

@sicet7 sicet7 added the C-feature-request Category: feature requested, but need to be discussed label Nov 25, 2024
@rustatian
Copy link
Member

Hey @sicet7 👋🏻
This is a great idea. We have the concept of the community-driven plugins: https://docs.roadrunner.dev/docs/community-plugins/intro. It can be in any organization, if you feel, that you can support it, feel free to let me know. You only need to make a PR into docs to describe your plugin, add Velox (roadrunner-server/velox) configuration to build RR with your plugin (also in docs) and then I'll post an update about that plugin to the RoadRunner channel in our Discord server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature-request Category: feature requested, but need to be discussed
Projects
None yet
Development

No branches or pull requests

2 participants