Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for "Between ... and ..." #15

Open
lsma opened this issue Sep 24, 2017 · 0 comments
Open

No support for "Between ... and ..." #15

lsma opened this issue Sep 24, 2017 · 0 comments

Comments

@lsma
Copy link

lsma commented Sep 24, 2017

Hey! I really appreciate this module. I've forked it and am trying to add support for strings like "Between September 12th and 22nd, 1914." I've gotten this to work by just adding "between" to ignoreable_chars and "and" to separator in create_parser. However, this lets in stuff like "January 12th and February 13th" which doesn't make much sense. Is this alright with you, and if so, should I go ahead with a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant