Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot open databases > 2 GiB #874

Open
MarianoFacundoArch opened this issue Nov 26, 2024 · 3 comments
Open

Cannot open databases > 2 GiB #874

MarianoFacundoArch opened this issue Nov 26, 2024 · 3 comments

Comments

@MarianoFacundoArch
Copy link
Contributor

I am getting error
RangeError [ERR_FS_FILE_TOO_LARGE]: File size (2400958314) is greater than 2 GiB
This is linked to:

nodejs/node#55864

Shouldn't we change the behavior to use buffers instead of readfile?
@MarianoFacundoArch
Copy link
Contributor Author

I just sent the pull request and added me to contributors as well if that's not an issue , to motivate myself to keep publishing improvements!

With this change, the performance is better, we now open files with the suggested way by nodejs, and we allow to open bigger databases as well!
Can somebody merge and release please? @runk

@runk runk mentioned this issue Nov 26, 2024
Closed
@MarianoFacundoArch
Copy link
Contributor Author

@runk Just reviewed your requests everything and did a new pull request:
#877

@MarianoFacundoArch
Copy link
Contributor Author

@runk Fixed the tests, latest PR:
#878

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@MarianoFacundoArch