Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close up to 3 upvalues in one opcode #26

Open
pliniker opened this issue Jul 7, 2020 · 0 comments
Open

Close up to 3 upvalues in one opcode #26

pliniker opened this issue Jul 7, 2020 · 0 comments
Labels
compiler Area: compiling easy Little experience and/or subject matter knowledge required

Comments

@pliniker
Copy link
Member

pliniker commented Jul 7, 2020

The CloseUpvalues opcode can take three operands, i.e. up to three upvalues can be closed in one operation. The present implementation lazily only does one.

See TODO: interpreter/src/compiler.rs:247

Refactor the loop to add up to three upvalues per CloseUpvalues opcode.
@pliniker pliniker added easy Little experience and/or subject matter knowledge required compiler Area: compiling labels Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler Area: compiling easy Little experience and/or subject matter knowledge required
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pliniker