Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Build::is_flag_supported /std:c++17 returns false on 1.2.1 ->1.2.5 transition (on x86_64-pc-windows-msvc) #1324

Open
dj8yfo opened this issue Dec 19, 2024 · 1 comment

Comments

@dj8yfo
Copy link

dj8yfo commented Dec 19, 2024

This is suppossedly a bug of https://docs.rs/cc/1.2.5/cc/struct.Build.html#method.is_flag_supported

on x86_64-pc-windows-msvc.

After applying diff near/cargo-near@4a4a772
, running build script in https://github.com/brson/wasm-opt-rs/blob/8854bd8a58d7393c7bacd950884aea521ce8e19f/components/wasm-opt-sys/build.rs#L365
fails https://github.com/near/cargo-near/actions/runs/12417889777/job/34669855813

Image
Image

Pinning cc to 1.2.1 in near/cargo-near#282 helps (build succeeds on the identical image)

@NobodyXu
Copy link
Collaborator

NobodyXu commented Dec 21, 2024

@dj8yfo I suspect it's because of f770d56

can you try forking cc and comment out that changes, and see if it fixes the problem for you please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants