We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi team,
Just came across a potential bug when trying to compute nodal correction.
In tides.py there are some MAJOR and MINOR cons declared at the beginning and combined into ALL_CONSTITUENTS
tides.py
ALL_CONSTITUENTS
This is later checked in get_nodal_correction (https://github.com/schism-dev/pyschism/blob/main/pyschism/forcing/bctides/tides.py#L275). If a cons is not in ALL_CONSTITUENTS (e.g. "L2"), this returns self._nodal_factors[constituent], which seems is not initialized. So it fails, although the correction information is indeed available further below https://github.com/schism-dev/pyschism/blob/main/pyschism/forcing/bctides/tides.py#L351
get_nodal_correction
The function 'add_constituents' that should initialize self._nodal_factors is never called it seems.
self._nodal_factors
Keen to hear your thoughts. Best Simon
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Hi team,
Just came across a potential bug when trying to compute nodal correction.
In
tides.pythere are some MAJOR and MINOR cons declared at the beginning and combined intoALL_CONSTITUENTSThis is later checked in
get_nodal_correction(https://github.com/schism-dev/pyschism/blob/main/pyschism/forcing/bctides/tides.py#L275). If a cons is not in ALL_CONSTITUENTS (e.g. "L2"), this returns self._nodal_factors[constituent], which seems is not initialized. So it fails, although the correction information is indeed available further below https://github.com/schism-dev/pyschism/blob/main/pyschism/forcing/bctides/tides.py#L351The function 'add_constituents' that should initialize
self._nodal_factorsis never called it seems.Keen to hear your thoughts.
Best
Simon
The text was updated successfully, but these errors were encountered: