Brightness #235
Open
Brightness #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
awesome! Small but very functional change similar to mine below (also first pr), I hope @scottlawsonbc / @joeybab3 can merge these additions asap :) |
joeybab3
approved these changes
Oct 24, 2019
joeybab3
approved these changes
Oct 24, 2019
|
So I went through and prepped it for merging but unfortunately, I have no way to test these changes for the time being as I left my LED strip and ESP's at home when I moved up to college. I do want to get back into this though so I will order a new set from china in hopes it will be here soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a brightness slider in the GUI and a correlating option in the config file.
I have only tested it with the esp8266. I changed stuff in led.py that might let the brightness slider work with the pi and blinkstick, but I'm not sure since I don't have either.
This is my first pull request to anyone. Please let me know if there is something I can improve on or something I forgot.