Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not scroll to element in iframe outside viewport #713

Open
92thunder opened this issue Jan 29, 2020 · 2 comments
Open

Does not scroll to element in iframe outside viewport #713

92thunder opened this issue Jan 29, 2020 · 2 comments

Comments

@92thunder
Copy link

I fixed scrollable if hidden by frame, but does not work scroll if iframe is outside viewport.
It seems that it is supported in native, so I think it should be supported.

@92thunder
Copy link
Author

@stipsan I have two ideas.

  • Returns frames[] traversed above iframe by compute-scroll-into-view.
  • If target is in iframe, recursively run behavior by scroll-into-view-if-needed.

I think the latter is better because the responsibilities are clear, but what about?

@92thunder 92thunder changed the title How do scroll to element in iframe of outside of viewport? How do scroll to element in iframe outside of viewport? Jan 29, 2020
@92thunder 92thunder changed the title How do scroll to element in iframe outside of viewport? Does not scroll to element in iframe outside viewport Jan 29, 2020
@92thunder
Copy link
Author

  • Returns frames[] traversed above iframe by compute-scroll-into-view.
  • If target is in iframe, recursively run behavior by scroll-into-view-if-needed.

After all, I fixed it with the above method.
Because, latter method is can't centering target if compute iframe as target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant