gasper changes for gctltoken generation #237
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhk19
requested changes
Feb 3, 2022
package-lock.json
Outdated
| @@ -0,0 +1,6 @@ | |||
| { | |||
services/master/middlewares/jwt.go
Outdated
| @@ -34,6 +34,19 @@ func authenticator(c *gin.Context) (interface{}, error) { | |||
| return user, nil | |||
| } | |||
|
|
|||
| func authenticatorForGctl(c *gin.Context) (interface{}, error) { | |||
| auth := &types.Login{} | |||
There was a problem hiding this comment.
didn't we decide to change this type? Is it working without a password in the request body?
| @@ -34,6 +34,19 @@ func authenticator(c *gin.Context) (interface{}, error) { | |||
| return user, nil | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
add a comment here that this function doesn't authenticate as authentication is already done in middleware.. this function is just to get the user
ZainulNiaz
force-pushed
the
gctltoken
branch
2 times, most recently
from
f1aaebf to
fd1a268
Compare
ZainulNiaz
force-pushed
the
gctltoken
branch
from
fd1a268 to
599fff8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes required to fix https://github.com/sdslabs/SWS/issues/24