Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Outlines version error for Grammar Backend #2550

Open
5 tasks done
zhaochenyang20 opened this issue Dec 23, 2024 · 5 comments
Open
5 tasks done

[Bug] Outlines version error for Grammar Backend #2550

zhaochenyang20 opened this issue Dec 23, 2024 · 5 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@zhaochenyang20
Copy link
Collaborator

Checklist

  • 1. I have searched related issues but cannot get the expected help.
  • 2. The bug has not been fixed in the latest version.
  • 3. Please note that if the bug-related issue you submitted lacks corresponding environment info and a minimal reproducible demo, it will be challenging for us to reproduce and resolve the issue, reducing the likelihood of receiving feedback.
  • 4. If the issue you raised is not a bug but a question, please raise a discussion at https://github.com/sgl-project/sglang/discussions/new/choose Otherwise, it will be closed.
  • 5. Please use English, otherwise it will be closed.

Describe the bug

Running SGLang latest version and outlines latest version:

ImportError: cannot import name 'build_regex_from_schema' from 'outlines.fsm.json_schema' (/opt/dlami/nvme/chenyang/miniconda3/envs/sglang/lib/python3.11/site-packages/outlines/fsm/json_schema.py)

I think it's just naming error. So I set this as a good-first-issue.

Reproduction

Easy to reproduce.

Environment

Easy to reproduce.

@zhaochenyang20 zhaochenyang20 self-assigned this Dec 23, 2024
@zhaochenyang20 zhaochenyang20 added bug Something isn't working good first issue Good for newcomers labels Dec 23, 2024
@zhaochenyang20
Copy link
Collaborator Author

Related to #2549 and #2292.

@shuaills
Copy link
Contributor

This might be related to the dependency conflict between vllm and sglang. sglang needs torch 2.4, but newer vllm versions require torch 2.5, which could be causing issues with outlines.

@zhaochenyang20
Copy link
Collaborator Author

This might be related to the dependency conflict between vllm and sglang. sglang needs torch 2.4, but newer vllm versions require torch 2.5, which could be causing issues with outlines.

Specifically, SGLang 0.4 now depends on torch 2.4. vllm 0.6.5 and 0.6.4 depend on torch 2.5. And vllm 0.6.5 depends on outlines 0.1.11, but openrlhf depends on vllm 0.6.5. So we give up on supporting them comparatively right now.

@gobraves
Copy link
Contributor

There’s an issue regarding the removal of vllm #2245 . Do we have any plans to continue working on this task?

@zhaochenyang20
Copy link
Collaborator Author

There’s an issue regarding the removal of vllm #2245 . Do we have any plans to continue working on this task?

Yeah. @zhyncs and Yi Zhang are continue working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants