New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use absolute paths in imports #2602

Open

merrymercy opened this issue Dec 26, 2024 · 0 comments

Assignees

Contributor

merrymercy commented Dec 26, 2024

We should prefer absolute imports in the all places

sglang/python/sglang/srt/distributed/__init__.py

Lines 1 to 3 in a74d194

    
           from .communication_op import * 
        
           from .parallel_state import * 
        
           from .utils import *

cc @yizhang2077

sglang/sgl-kernel/src/sgl-kernel/ops/__init__.py

Line 1 in a74d194

from .moe_align_block_size import moe_align_block_size as _moe_align_block_size

cc @zhyncs

zhyncs assigned yizhang2077 and zhyncs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment