Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove application_static from docs due to Webpacker changes #407

Open
justin808 opened this issue Jul 15, 2017 · 10 comments
Open

Remove application_static from docs due to Webpacker changes #407

justin808 opened this issue Jul 15, 2017 · 10 comments

Comments

@justin808
Copy link
Member

Per this search:

https://github.com/shakacode/react-webpack-rails-tutorial/search?utf8=%E2%9C%93&q=application_static&type=

This needs cleanup.

@rnice01
Copy link

rnice01 commented Jul 22, 2017

Hey I'd like to help out with this if I could, seems simple enough.

@justin808
Copy link
Member Author

@rnice01 Please start on this! I'll mark this taken by you, but you have only a few days to show progress. Get in touch if you want a Slack invite as well. And we need to update the docs for https://github.com/shakacode/react_on_rails.

@ramrudra
Copy link

@justin808 I'll pick this up

ramrudra added a commit to ramrudra/react-webpack-rails-tutorial that referenced this issue Aug 26, 2018
@singhvaibhavram
Copy link

@justin808 I would like to take this.

@justin808
Copy link
Member Author

@singhvaibhavram Sure. If we can get proper HMR working as well, that would be great.

@ramrudra
Copy link

@justin808 @singhvaibhavram PR #446 is for this specific issue.

@singhvaibhavram
Copy link

singhvaibhavram commented Aug 27, 2018 via email

@singhvaibhavram
Copy link

@ramrudra can you msg me on slack? I have to ask you something regarding the pull request you made.
slack email: [email protected]

@singhvaibhavram
Copy link

@justin808 I have messaged you on slack for some doubts.

@ramrudra
Copy link

@singhvaibhavram Sure.

@justin808 Could you please send me a slack invite on [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants