Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write better PR templates #5

Open
jku opened this issue Nov 10, 2023 · 1 comment
Open

Write better PR templates #5

jku opened this issue Nov 10, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@jku
Copy link
Member

jku commented Nov 10, 2023

  • should make it clear that PRs for metadata changes should happen via signing events (so issues with a "sign/*" branch)
@jku jku added the enhancement New feature or request label Nov 10, 2023
@jku jku mentioned this issue Nov 10, 2023
Closed
@jku
Copy link
Member Author

jku commented Mar 7, 2024 •
edited
Loading

My plan here is roughly:

  • PRs from signers to a signing event: make the tool create the PR and use a custom template. This means root-signing-staging can include content in that template that e.g. pings the maintenance team to merge to the signing event Improve non-maintainer signer flow theupdateframework/tuf-on-ci#209
  • Generic PR template:
    • Include something like "If you are trying to contribute to an existing signing event, something has gone wrong"
    • As well as "If you are trying to start a signing event for an artifact change, please push a branch prefixed with sign/ to upstream instead"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jku