Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1789666: Resolve NPM deprecation warning @azure/[email protected] #948

Open
dar-yl opened this issue Nov 6, 2024 · 7 comments
Open

SNOW-1789666: Resolve NPM deprecation warning @azure/[email protected] #948

dar-yl opened this issue Nov 6, 2024 · 7 comments
Assignees
@sfc-gh-dszmolka
Labels
enhancement The issue is a request for improvement or a new feature status-pr_pending_merge A PR is made and is under review status-triage_done Initial triage done, will be further handled by the driver team

Comments

@dar-yl
Copy link

dar-yl commented Nov 6, 2024 •
edited
Loading

Related - @aws-sdk/[email protected] deprecation: #947

  1. What version of NodeJS driver are you using?
    1.14.0

  2. What operating system and processor architecture are you using?
    N/A

  3. What version of NodeJS are you using?
    Node: 20.17.0 / NPM: 10.8.2

  4. What are the component versions in the environment (npm list)?

    [email protected]
└── [email protected]

  5. What did you do?
    Install the Node [email protected]. Refer to NPM deprecation warnings...

    npm i [email protected]
# ...
npm warn deprecated @azure/[email protected]: This package is no longer supported. Please migrate to use @azure/core-rest-pipeline

  6. What did you expect to see?
    No deprecation warnings.

  7. Can you collect debug logs?
    N/A
@dar-yl dar-yl added the bug Something isn't working label Nov 6, 2024
@github-actions github-actions bot changed the title Resolve NPM deprecation warning @azure/[email protected] SNOW-1789666: Resolve NPM deprecation warning @azure/[email protected] Nov 6, 2024
@sfc-gh-dszmolka
Copy link
Collaborator

hi - thank you for drawing attention to this, not entirely sure why we need 2 separate issues but works for us. we'll look into this.

@sfc-gh-dszmolka sfc-gh-dszmolka self-assigned this Nov 6, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka added status-triage_done Initial triage done, will be further handled by the driver team and removed bug Something isn't working labels Nov 6, 2024
@dar-yl dar-yl mentioned this issue Nov 6, 2024
Closed
@sfc-gh-dszmolka sfc-gh-dszmolka added the status-in_progress Issue is worked on by the driver team label Nov 6, 2024
@sfc-gh-dszmolka
Copy link
Collaborator

the deprecated package @azure/core-http comes as a transient dependency (from our pre-12.23.0 @azure/storage-blob) direct dependency)
PR in draft #951

@sfc-gh-dszmolka sfc-gh-dszmolka added status-blocked Progress cannot be made to this issue due to an outside blocking factor. and removed status-in_progress Issue is worked on by the driver team labels Nov 7, 2024
@sfc-gh-dszmolka
Copy link
Collaborator

sfc-gh-dszmolka commented Nov 7, 2024 •
edited
Loading

tests on Azure node 14.x are failing, the upgraded library does not seem to support node:14 (needs node:18), so likely we'll need to wait until we deprecate node:14 . at this moment (7 November 2024) we still list under the supported runtimes.

putting this issue in blocked status until support for node:14 is dropped from Snowflake node.js driver.

edit: turned out that after all it was a good idea to create 2 separate issues for the aws and the azure library deprecations :)

@sfc-gh-dszmolka sfc-gh-dszmolka mentioned this issue Nov 20, 2024
Closed
5 tasks
@sfc-gh-dszmolka
Copy link
Collaborator

we'll drop node:14 (and 16, and 17..) support with the next version, so will come back to this after release

@dar-yl
Copy link
Author

dar-yl commented Dec 16, 2024

@sfc-gh-dszmolka we're unblocked here now. Thanks for the help so far :)

@sfc-gh-dszmolka sfc-gh-dszmolka added enhancement The issue is a request for improvement or a new feature and removed status-blocked Progress cannot be made to this issue due to an outside blocking factor. labels Dec 16, 2024
@sfc-gh-dszmolka
Copy link
Collaborator

thanks for the feedback @dar-yl - indeed v2 is released so we dropped support , so can resume with the PR.
now we have a different issue: failures on the test infra. Keeping an eye out for its resolution and if it's clear then will continue with #951, which can be followed for progress if you wish

@sfc-gh-dszmolka sfc-gh-dszmolka added the status-pr_pending_merge A PR is made and is under review label Dec 17, 2024
@sfc-gh-dszmolka
Copy link
Collaborator

test infra looks to be healed; PR is open for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfc-gh-dszmolka sfc-gh-dszmolka

Labels
enhancement The issue is a request for improvement or a new feature status-pr_pending_merge A PR is made and is under review status-triage_done Initial triage done, will be further handled by the driver team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sfc-gh-dszmolka @dar-yl