Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

[RDS] Use Spring Tomcat Datasource properties in default Tomcat datasource #739

Open
Kraignos opened this issue Nov 30, 2020 · 1 comment
Labels
component: rds RDS integration related issue

Comments

@Kraignos
Copy link

Would it be possible to get the following Spring datasource properties and integrate them in the TomcatJdbcDataSourceFactory class when you create a new datasource within the createDataSource method ?
For now, it is instanciated with the default values coming from the Tomcat class PoolProperties, but it makes sense to consider those properties that spring provides inside this default datasource factory.

This would allow us to override some configuration of the pool such as the timeouts, number of connections, etc. without having to create a configuration class for it.

@github-actions github-actions bot added the status: waiting-for-triage An issue we've not yet triaged label Nov 30, 2020
@eddumelendez
Copy link
Contributor

Hi @Kraignos you can use DataSourceAutoConfiguration from spring-boot which means using spring.datasource.* configuration properties. Wondering if you are using spring-cloud-aws-jdbc for any special reason?

@eddumelendez eddumelendez added component: rds RDS integration related issue and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: rds RDS integration related issue
Development

No branches or pull requests

2 participants