Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the closing of all the piemenus #4050

Open
omsuneri opened this issue Nov 13, 2024 · 3 comments
Open

Optimize the closing of all the piemenus #4050

omsuneri opened this issue Nov 13, 2024 · 3 comments

Comments

@omsuneri
Copy link
Contributor

Current Behavior

Currently we have to click on the cancle button in order to close the piemenu we open like the context menu, grid menu and all
so this might somewhat be optimized.

Desired Behavior

the main task is to allow all the piemenus to close whenever you click somewhere in the canvas along.
also the thing we need to think of is to make the code more optimistic.

Screenshots / Mockups

Screenshot 2024-11-13 at 6 01 50 PM Screenshot 2024-11-13 at 6 04 21 PM

along with these two piemenus we have to make all of them to work accordingly.

Implementation

just to simply recreate the cancle function of the piemenus in an optimistic manner.

Acceptance Tests

N/a

Environment

  • Operating System: [e.g., Windows, macOS, Linux]
  • Browser (if applicable): [e.g., Chrome, Firefox, Safari]
  • Version of Software/Project: [e.g., v1.0.0]

Additional Information

Checklist

  • [y] I have read and followed the project's code of conduct.
  • [y] I have searched for similar issues before creating this one.
  • [y] I have provided all the necessary information to understand and reproduce the issue.
  • [y] I am willing to contribute to the resolution of this issue.

Thank you for contributing to our project! We appreciate your help in improving it.

📚 See contributing instructions.

🙋🏾🙋🏼 Questions: Community Matrix Server.

@omsuneri
Copy link
Contributor Author

omsuneri commented Nov 13, 2024

I m working on this issue and recreating the hide event and make them work accordingly desired.

@justin212407
Copy link
Contributor

@omsuneri i was looking at this issue and trying to recreate it looks like the current behavior is only on the context menu and not the grid menu

@omsuneri
Copy link
Contributor Author

omsuneri commented Dec 6, 2024

@justin212407 nice to hear this but I think this might not be needed anymore as I had talked with Walter and also I m working on this so it will be better if you try to tackle some another issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants