Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax error in watchdog #64

Open
myndzi opened this issue Nov 25, 2024 · 0 comments
Open

Syntax error in watchdog #64

myndzi opened this issue Nov 25, 2024 · 0 comments

Comments

@myndzi
Copy link

myndzi commented Nov 25, 2024

https://github.com/tapjs/foreground-child/blob/main/src/watchdog.ts#L25

There's an extra ) in the code, so the watchdog process never successfully spawns. I was going to send a PR, but I don't quite understand the full intentions of this library. It's surprising to me that the tests don't catch this, so I got a bit lost when trying to decide how to write a test that will fail here and succeed when the typo is fixed.

Beyond that, there should probably be some defined behavior for if the watchdog exits unexpectedly - for example, kill the child, since the watchdog is incapable of doing its job - but that's a design decision best left to y'all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant