Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in test/intl402/NumberFormat/currency-digits-nonstandard-notation.js #4349

Open
iamstolis opened this issue Dec 13, 2024 · 0 comments
Open

Bug in test/intl402/NumberFormat/currency-digits-nonstandard-notation.js #4349

iamstolis opened this issue Dec 13, 2024 · 0 comments

Comments

@iamstolis
Copy link
Contributor

The test added by #4274 (i.e. test/intl402/NumberFormat/currency-digits-nonstandard-notation.js) contains an incorrect assertion for maximumFractionDigits. It requires them to be 3 but they should be 0 when the notation is compact, see this comment for details.

In other words, there should be something like

assert.sameValue(maximumFractionDigits, (notation === 'compact') ? 0 : 3, ...

instead of

assert.sameValue(maximumFractionDigits, 3, ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iamstolis