-
Notifications
You must be signed in to change notification settings - Fork 936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra(graphql): upgrade graphql to v16 and apollo-server to v4 #8753
Open
luvkapur
wants to merge
41
commits into
master
Choose a base branch
from
graphql-apollo-update
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eer in the latest
…rom apollo-client. Create ws connection using graphql-ws
luvkapur
commented
Apr 30, 2024
StarHosea
approved these changes
Jun 26, 2024
luvkapur
changed the title
chore(graphql): upgrade graphql to v16 and apollo-server to v4
infra(graphql): upgrade graphql to v16 and apollo-server to v4
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
graphql
andapollo-server
version to the latest.One of the key update is dropping the dependency on
subscription-transport-ws
to implement websockets and graphql subscriptions.subscription-transport-ws
is not maintained and has numerous security issues. We replacesubscription-transport-ws
with thegraphql-ws
which is the recommended lib to implement web sockets and graphql subscriptions.This PR also fixes subscriptions in the workspace. Previously, even though the schema had subscriptions defined for component updates in the workspace, it wasn't implemented correctly which resulted in the client never receiving any live updates from the server. With this fix, now the client receives live updates from the workspace regarding component updates (additions, modifications, deletions)
Workspace Live Updates
Apollo 4 Playground