Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export pch_table #4034

Open
atusy opened this issue May 27, 2020 · 2 comments · May be fixed by #6236
Open

Export pch_table #4034

atusy opened this issue May 27, 2020 · 2 comments · May be fixed by #6236
Labels
documentation scales 🐍

Comments

@atusy
Copy link
Contributor

atusy commented May 27, 2020

#2338 did a great job that helps chosing shapes (pch).
Yet, we still have to see vignette to find full name list of shapes.
I'd suggest exporting pch_table, which is currently inside the translate_shape_string.

ggplot2/R/geom-point.r

Line 145 in 2b03e47

pch_table <- c(

Also, I'd suggest pch_table to have a unique class, and implement autoplot method to draw the plot below by autoplot(pch_table)

(from #2075 (comment))

If my suggestion sounds nice, I'd be happy to work on a PR.
@yutannihilation
Copy link
Member

Maybe we can just embed this image on the help of scale_shape?

@atusy
Copy link
Contributor Author

atusy commented Jul 1, 2020

That sounds nice.
BTW, I just noticed the better image is available via an vignette ( https://ggplot2.tidyverse.org/articles/ggplot2-specs.html#point-1).

@teunbrand teunbrand linked a pull request Dec 12, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation scales 🐍
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include image of shape table teunbrand/ggplot2
3 participants
@thomasp85 @yutannihilation @atusy