Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicts in service discovery caused by new worker service sharing the same annotations as coordinator #269

Open
rotem-ad opened this issue Dec 2, 2024 · 0 comments

Comments

@rotem-ad
Copy link
Member

rotem-ad commented Dec 2, 2024

Ran into this issue after upgrading to the latest Trino chart version.

We rely on K8s service annotations to discover services using HashiCorp Consul - See Service Sync for Consul on Kubernetes.
Particularly, we use service annotations to discover Trino coordinator service.

This change in PR #227 made the new worker service share the exact same annotations as the coordinator service. This affected our service discovery system, causing it to register both coordinator and worker nodes as coordinators.

Can we please support setting service annotations separately for each service?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant