Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alembic support for Trino #287

Open
1 task
sergio-ropero opened this issue Nov 15, 2022 · 1 comment
Open
1 task

Alembic support for Trino #287

sergio-ropero opened this issue Nov 15, 2022 · 1 comment

Comments

@sergio-ropero
Copy link

Describe the feature

It would be awesome to use Alembic for Trino in order to apply migrations and being able to rollback.
That can help with the CI/CD pipelines without overthinking an in-house solution when the technology is already in place.

Also, the Trino dialect is already implemented so it's a matter to connect the dots between the dialect and the Alembic usage (like the Imp for postgresql as example).

Describe alternatives you've considered

I have been able to use it with a workaround creating an empty implementation with the trino dialect but a proper implementation would be better and more functional:

from alembic.ddl.impl import DefaultImpl


class TrinoImpl(DefaultImpl):
    __dialect__ = 'trino'

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@hashhar
Copy link
Member

hashhar commented Sep 3, 2024

We can use https://github.com/SAP/sqlalchemy-hana/blob/main/sqlalchemy_hana/alembic.py as inspiration for when we work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants