Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: SQLAlchemy async #408

Open
1 task
hongbo-miao opened this issue Sep 9, 2023 · 2 comments
Open
1 task

Feature request: SQLAlchemy async #408

hongbo-miao opened this issue Sep 9, 2023 · 2 comments

Comments

@hongbo-miao
Copy link

hongbo-miao commented Sep 9, 2023

Describe the feature

It would be great to provide a SQLAlchemy async demo, thanks!

SQLAlchemy says it supports async since version 1.4

This repo readme says

trino.sqlalchemy is compatible with the latest 1.3.x and 1.4.x SQLAlchemy versions at the time of release of a particular version of the client.

https://docs.sqlalchemy.org/en/20/orm/extensions/asyncio.html

However, I cannot make them work.

I guess for SQLAlchemy, I need install

pip install sqlalchemy[asyncio]

This repo I need run

pip install trino[sqlalchemy]

Apparently, this does not exist 🥲

pip install trino[sqlalchemy[asyncio]]

I guess it may be blocked by this #3 (?)

Describe alternatives you've considered

Use https://github.com/mvanderlee/aiotrino instead. However, it would be great to support async officially including SQLAlchemy async. Thanks!

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@hovaesco
Copy link
Member

Async SQLAlchemy is not supported currently for trino-python-client.

@hongbo-miao hongbo-miao changed the title Provide SQLAlchemy async demo Feature request: SQLAlchemy async Sep 12, 2023
@hongbo-miao
Copy link
Author

Thanks @hovaesco for clarification! I guess it would be a feature request. Just updated the title. Hopefully one day can support. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants