Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commonjs plugin should not include .ts extension #396

Open
juetan opened this issue May 8, 2024 · 3 comments
Open

commonjs plugin should not include .ts extension #396

juetan opened this issue May 8, 2024 · 3 comments
Labels

Comments

@juetan
Copy link

juetan commented May 8, 2024

Environment

node 20

Reproduction

no

Describe the bug

in /src/builder/rollup.ts file, commonjs should not include .ts extension, is that expected?
image

Additional context

No response

Logs

No response

@pi0
Copy link
Member

pi0 commented May 8, 2024

no (reproduction please)

@pi0 pi0 closed this as not planned Won't fix, can't repro, duplicate, stale May 8, 2024
@juetan
Copy link
Author

juetan commented May 9, 2024

no (reproduction please)

https://stackblitz.com/edit/vitejs-vite-z6f6jw?file=build.config.ts

when declaration: true, it build fail. then add rollup.commonjs.extensions,it works.

@pi0 pi0 reopened this May 9, 2024
@pi0
Copy link
Member

pi0 commented May 9, 2024

Thanks for the reproduction. It seems the issue is with dts build step (since we bundle, usually importing ts in cjs context should be also doable)

@pi0 pi0 added the dts label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants