Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Yo tool to match current template #2399

Open
preetkaran20 opened this issue Oct 11, 2020 · 8 comments
Open

Update Yo tool to match current template #2399

preetkaran20 opened this issue Oct 11, 2020 · 8 comments
Labels
bug discussion open-ended issues that haven't yet defined what needs to be worked on up-for-grabs

Comments

@preetkaran20
Copy link
Contributor

Hi Team,

I have recently added my Project Owasp VulnerableApp to the up-for-grabs using YO generator and i found that there are gaps between the tool and the actual requirement of the PR(Build Actions) and hence user has to-fro multiple times as an example:
Tools doesn't have validations or at a minimal text help which mentioned validations like : is not allowed or space in tags is not allowed, lower-case letters are only allowed etc.

I think validations should be added to YO generator tool and if not possible please add text mentioning the same at each input step. I think it is important.

thanks,
Karan

@preetkaran20
Copy link
Contributor Author

PR where i faced this issue: #2380

@ritwik12 ritwik12 added bug discussion open-ended issues that haven't yet defined what needs to be worked on up-for-grabs labels Oct 11, 2020
@ritwik12
Copy link
Collaborator

@preetkaran20 Thanks for opening this :)

@shiftkey
Copy link
Member

@preetkaran20 thanks for the heads up - you're right that it's very out of date with what we currently support and probably needs some improvements. We have the code available over in https://github.com/up-for-grabs/generator-up-for-grabs but I haven't had time to dig into what needs to change. I'm also not that familiar with how it works.

If we find ourselves needing to publish a new update to NPM I'll need to ask @ChrisMissal for access on NPM.

@shiftkey shiftkey changed the title Regarding gaps in Yo Generator tool Update Yo tool to match current changes Oct 12, 2020
@shiftkey shiftkey changed the title Update Yo tool to match current changes Update Yo tool to match current template Oct 12, 2020
@g-kabra
Copy link

g-kabra commented Oct 12, 2022

Hey! I'd like to try solving this issue. At the very least, I can add messages regarding the format of expected input, and if possible, I will try to add regex filters which will check if input is of the correct form. I will need a list of validations to be performed though, a few are listed in the issue, but it would be easier for me to have a full list so as to make a comprehensive validation filter.

@shiftkey
Copy link
Member

@g-kabra I'm very hazy on what's needed here but feel free to take a shot at it

@g-kabra
Copy link

g-kabra commented Oct 13, 2022

Hey @shiftkey . I've tried implementing what I understood from the issue here. Check out my PR over here. Let me know if it works for you or needs any changes!

@Ashcjs
Copy link

Ashcjs commented Oct 28, 2022

Backup-codes-pitreb913.txt

Have you finished this file yet?Backup-codes-pitreb913.txt

Have you finished this file yet?Backup-codes-pitreb913.txt

Have you finished this file yet?Backup-codes-pitreb913.txt

Have you finished this file yet?

@Ashcjs
Copy link

Ashcjs commented Oct 28, 2022

_data/projects/Appsmith.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug discussion open-ended issues that haven't yet defined what needs to be worked on up-for-grabs
Projects
None yet
Development

No branches or pull requests

5 participants